Ignore ANSI colour codes in printing Diagonal, etc #47430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
26 tasks
KristofferC
pushed a commit
that referenced
this pull request
Dec 14, 2022
(cherry picked from commit 9f572b6)
KristofferC
pushed a commit
that referenced
this pull request
Dec 14, 2022
(cherry picked from commit 9f572b6)
KristofferC
pushed a commit
that referenced
this pull request
Dec 14, 2022
(cherry picked from commit 9f572b6)
jishnub
pushed a commit
to JuliaArrays/BlockArrays.jl
that referenced
this pull request
Jan 12, 2025
Previously, BlockArrays with elements that used styling would throw off the printing, because the textwidth computation didn't account for the fact that some contents might have a different `length` relative to how much space they take up when printed. This fixes that by using the `ANSIIterator` from Base, ala JuliaLang/julia#47430. Unfortunately, `ANSIIterator` isn't exported at the moment - but the alternative is to depend on StringManipulations.jl or copy over the Base implementation. I added a test that shows the problem. Previously, it displayed as:  With this, it displays as: 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #45751
Uses ANSIIterator from #45521 so that the printing of structured matrices isn't thrown off by the presence of invisible colour codes.