[Makefile] Clean generated headers out of SRCDIR #47755
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It is unclear to me that we should be changing the SRC directory in make clean. That would be unexpected to me when building. Why is the build picking up the wrong file? While usually |
brenhinkeller
added
the
building
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After wasting yet another 30min staring at my out-of-tree being borked and remembering that weird errors
can occur when one accidentially hit
makein the source tree, and then switched backed to an out-of-treebuild dir.
The issue is that one can easily have a remnant of a
jl_internal_funcs.inclaying around, which will takeprecedent over the new one generate in the out-of-tree builddir.