Skip to content

Change @test ex broken=true to error if ex evaluates to non-boolean #47804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 22, 2022
Merged

Change @test ex broken=true to error if ex evaluates to non-boolean #47804

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
92bb4f0
Change `@test ex broken=true` to error if `ex` evaluates to non-boolean
staticfloat Dec 5, 2022
b33d7c7
Remove wrong `@test_broken @inferred` test
staticfloat Dec 21, 2022
508bb92
Fix `@test_broken` to actually assert type intersection result
staticfloat Dec 21, 2022
e4c064b
Modify `@test_broken` on `cfunction` platform support failure
staticfloat Dec 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions stdlib/Test/src/Test.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -674,8 +674,13 @@ function do_broken_test(result::ExecutionResult, orig_expr)
# Assume the test is broken and only change if the result is true
if isa(result, Returned)
value = result.value
if isa(value, Bool) && value
testres = Error(:test_unbroken, orig_expr, value, nothing, result.source)
if isa(value, Bool)
if value
testres = Error(:test_unbroken, orig_expr, value, nothing, result.source)
end
else
# If the result is non-Boolean, this counts as an Error
testres = Error(:test_nonbool, orig_expr, value, nothing, result.source)
end
end
record(get_testset(), testres)
Expand Down
2 changes: 1 addition & 1 deletion test/ccall.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1020,7 +1020,7 @@ end

else

@test_broken "cfunction: no support for closures on this platform"
@test_broken "cfunction: no support for closures on this platform" === nothing

end

Expand Down
3 changes: 1 addition & 2 deletions test/sets.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -734,8 +734,7 @@ end
x = @inferred replace([1, 2], 2=>missing)
@test isequal(x, [1, missing]) && x isa Vector{Union{Int, Missing}}

@test_broken @inferred replace([1, missing], missing=>2)
x = replace([1, missing], missing=>2)
x = @inferred replace([1, missing], missing=>2)
@test x == [1, 2] && x isa Vector{Int}
x = @inferred replace([1, missing], missing=>2, count=1)
@test x == [1, 2] && x isa Vector{Union{Int, Missing}}
Expand Down
2 changes: 1 addition & 1 deletion test/subtype.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2230,7 +2230,7 @@ T46784{B<:Val, M<:AbstractMatrix} = Tuple{<:Union{B, <:Val{<:B}}, M, Union{Abstr
(Tuple{Type{T},Array{Union{T,Nothing},N}} where {T,N})) <: Any

#issue 35698
@test_broken typeintersect(Type{Tuple{Array{T,1} where T}}, UnionAll)
@test_broken typeintersect(Type{Tuple{Array{T,1} where T}}, UnionAll) != Union{}

#issue 33137
@test_broken (Tuple{Q,Int} where Q<:Int) <: Tuple{T,T} where T
Expand Down