Continue working to make GlobalRef more first-class #47929
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
force-pushed
the
jn/globalref-binding
branch
from
c13ca30 to
3dbd413
Compare
The `owner` field now points directly at the target binding (which may be itself), rather than indirecting through a module+name re-lookup. This makes `module X; import .x as y; end` behavior more precise. The `globalref` field is currently now mandatory, since otherwise incremental compilation will be impossible right now. Maybe world-age splitting will help improve that later? Fix up a lot of locations that previously used the `name` field badly. There are some valid uses of this, but mostly it was wrong, since it would may fail to reflect what content actually appeared in the user's code. Directly forwarding the actual lookup result is cleaner and clearer for the user in most cases. Also remove `resolve` for GlobalRef: This has been wrong since `import as` was added, and appears unused and untested.
vtjnash
force-pushed
the
jn/globalref-binding
branch
from
3dbd413 to
ac109e6
Compare
The owner field is now handled with cmpswap, so we can avoid needing a module lock for it. This now means we only need the module lock for handling the bindings and usings fields.
vtjnash
force-pushed
the
jn/globalref-binding
branch
from
ac109e6 to
fae53d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ownerfield now points directly at the target binding (which may be itself), rather than indirecting through a module+name re-lookup. This makesmodule X; import .x as y; endbehavior more precise.The
globalreffield is currently now mandatory, since otherwise incremental compilation will be impossible right now. Maybe world-age splitting will help improve that later?Fix up a lot of locations that previously used the
namefield badly. There are some valid uses of this, but mostly it was wrong, since it would may fail to reflect what content actually appeared in the user's code. Directly forwarding the actual lookup result is cleaner and clearer for the user in most cases.Also remove
resolvefor GlobalRef:This has been wrong since
import aswas added, and appears unused and untested.@Keno you probably should review this, since you were the most interested in seeing Binding become more first-class