Skip to content

Change permissions of stdlib pkgimgs #48019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 28, 2022
Merged

Change permissions of stdlib pkgimgs #48019

merged 2 commits into from
Dec 28, 2022

Conversation

@gbaraldi
Copy link
Member

@gbaraldi gbaraldi commented Dec 28, 2022

No description provided.

@gbaraldi gbaraldi requested a review from staticfloat December 28, 2022 14:28
@KristofferC KristofferC added the backport 1.9 Change should be backported to release-1.9 label Dec 28, 2022
@vchuravy
Copy link
Member

vchuravy commented Dec 28, 2022

Is this something we should do generally when we create them?

@gbaraldi
Copy link
Member Author

gbaraldi commented Dec 28, 2022 •
edited
Loading

Maybe?
Elliot said:

It is understandable that the pkgimage generation code only assigns the user executable bit, since it is, in general, sitting in a user’s home directory. However, since we are shipping a distribution here, we should alter the executable bits at make install time.

which seems reasonable.

@staticfloat
Copy link
Member

staticfloat commented Dec 28, 2022

I think if you’re okay with making it more permissive, that would avoid one potential stumbling block in case sys admins want to run a shared depot.

@vchuravy
Copy link
Member

vchuravy commented Dec 28, 2022

Yeah, I see no issue with that. The place to change it is

julia/base/loading.jl

Line 2087 in 82fbf54

chmod(tmppath_so, filemode(path) & 0o777 | 0o300)

staticfloat
staticfloat reviewed Dec 28, 2022
View reviewed changes
@gbaraldi @staticfloat
Update base/loading.jl
f758151 
Co-authored-by: Elliot Saba <[email protected]>
@staticfloat staticfloat merged commit 58d9c87 into JuliaLang:master Dec 28, 2022
KristofferC pushed a commit that referenced this pull request Dec 28, 2022
@gbaraldi @staticfloat @KristofferC
Change permissions of stdlib pkgimgs (#48019)
6ae7827 
* Change permissions of pkgimgs

* Update base/loading.jl

Co-authored-by: Elliot Saba <[email protected]>

Co-authored-by: Elliot Saba <[email protected]>
(cherry picked from commit 58d9c87)
@KristofferC KristofferC mentioned this pull request Dec 28, 2022
Merged
14 tasks
@staticfloat
Copy link
Member

staticfloat commented Dec 28, 2022

julia-58d9c87fc5/share/julia/compiled/v1.10/LLD_jll/ZHBMJ_epoh3.dylib: replacing existing signature

Codesigning changes are looking good!

The staple and validate action worked!

Notarization worked, thanks Gabriel!

@DilumAluthge DilumAluthge mentioned this pull request Dec 29, 2022
Open
@KristofferC KristofferC removed the backport 1.9 Change should be backported to release-1.9 label Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@staticfloat staticfloat staticfloat left review comments

@vchuravy vchuravy vchuravy approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gbaraldi @vchuravy @staticfloat @KristofferC