Breaking up ReinterpretArray methods by typcasting type to enable more optimizations #48138
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a
TypecastStyleinterface to theReinterpretArraymethods to make the it simpiler to add some optimizations that were missing. Particularly typecasting to a larger type in a continuous array.The main changes were to the _getindex_ra & _setindex_ra methods which are now dispatched on based on TypecastStyle. This should make further optimization easier in the future.
This was somewhat inspired by the issue #31305. It does provide a speedup of nearly 10x when you have a bounds checking active with an accessor type function.
The following benchmark code was used:
The results on master:
vs This branch