Add a wait(::[Abstract]WorkerPool)
#48238
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
approved these changes
Feb 10, 2024
Member
fingolfin
left a comment
fingolfin
left a comment
There was a problem hiding this comment.
Thanks you @kleinschmidt -- This seems like a very sensible addition. Lots of people added nice emoji reactions to it, too, but somehow nobody approved and merged :-(
In the meantime Distributed was moved into its own repository. Would you perhaps be willing to re-open this in a new PR at https://github.com/JuliaLang/Distributed.jl/pulls ?
Member
|
Moved to issue JuliaLang/Distributed.jl#86. Since it is already approved here, it can merge once that is opened over there. |
fatteneder
added a commit
to fatteneder/Distributed.jl
that referenced
this pull request
Jul 18, 2024
Original PR: JuliaLang/julia#48238 Co-authored-by: kleinschmidt <[email protected]>
fatteneder
added a commit
to JuliaLang/Distributed.jl
that referenced
this pull request
Jul 25, 2024
Original PR: JuliaLang/julia#48238 Co-authored-by: kleinschmidt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was surprised to find that there was no method for
Base.waiton aWorkerPoolwhich blocks until a worker is ready and then returnsnothing. This adds a straightforward method based on thewp_local_$fpattern, that just callswait(pool.channel). I've added tests (for both local and remote invocations) and will update docs as well.