[release-1.9] Atomically order specsigflags, specptr, and invoke (#47832) #48874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backport the fix for `GotoIfNot` effects modeling to 1.9
Since we allow overloading of the `bail_out_xxx` hooks, we need to make sure that we widen both type and effects to the top when bailing on inference regardless of the condition presumed by a hook. This commit particularly fixes the correctness of `bail_out_apply` (fixes #48807). I wanted to make a simplified test case for this, but it turns out to be a bit tricky since it relies on the details of multiple match analysis and the bail out logic.
vchuravy
approved these changes
Mar 2, 2023
vchuravy
changed the title
|
Required to backport 48723 to 1.9, which I would like to have in rc1 |
Co-authored-by: Jameson Nash <[email protected]> Co-authored-by: Dilum Aluthge <[email protected]> (cherry picked from commit 6412a56)
pchintalapudi
force-pushed
the
pc/backport-47832
branch
from
ef2ea6c to
1cf35bc
Compare
KristofferC
force-pushed
the
backports-release-1.9
branch
from
d5651bc to
b07fb40
Compare
|
Thanks @pchintalapudi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Jameson Nash [email protected]
Co-authored-by: Dilum Aluthge [email protected]
(cherry picked from commit 6412a56)
This is necessary to backport #48723 to 1.9.