simplify Broadcast object computations #49395
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
force-pushed
the
jn/simplify-broadcast-cntr
branch
2 times, most recently
from
a0fae36 to
05c6296
Compare
Code should normally preserve values, not the types of values. This ensures the user can define styles with metadata, and requires less type-parameter-based programming, but rather can focus on the values.
vtjnash
force-pushed
the
jn/simplify-broadcast-cntr
branch
from
05c6296 to
5d0a527
Compare
N5N3
added a commit
to N5N3/julia
that referenced
this pull request
Oct 14, 2023
On master, `combine_styles(bc::Broadcasted)` calls `BroadcastStyle(typeof(bc))`, which seems bad after JuliaLang#49395 as it has a `Style()` call.
N5N3
added a commit
that referenced
this pull request
Oct 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code should normally preserve values, not the types of values. This ensures the user can define styles with metadata, and requires less type-parameter-based programming, but rather can focus on the values.
Note that this style of functions should be better eventually (for latency and memory use), but currently isn't yet optimally dealt with since in the runtime we still generate and preserve unnecessary
convert(typeof(args), args)calls via fieldtypes, and so we separately need to improve lowering and/or inference to work better on this, where one of the elements of theargstuple is inferred asAny.