Skip to content

follow up #49812, fix the wrong type declaration #49854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 17, 2023
Merged

follow up #49812, fix the wrong type declaration #49854

merged 1 commit into from
May 17, 2023

Conversation

@aviatesk
Copy link
Member

#49812 introduced a bug and broke the CI. This commit fixes it up.

@aviatesk
follow up #49812, fix the wrong type declaration
28fb93f 
#49812 introduced a bug and broke the CI.
This commit fixes it up.
@aviatesk aviatesk added embarrassing-bugfix Whoops! merge me PR is reviewed. Merge when all tests are passing labels May 17, 2023
@KristofferC KristofferC added the backport 1.9 Change should be backported to release-1.9 label May 17, 2023
@KristofferC KristofferC merged commit 869c70e into master May 17, 2023
@KristofferC KristofferC deleted the avi/loading-again branch May 17, 2023 17:47
@oscardssmith oscardssmith removed the merge me PR is reviewed. Merge when all tests are passing label May 17, 2023
@KristofferC KristofferC mentioned this pull request May 19, 2023
Merged
51 tasks
KristofferC pushed a commit that referenced this pull request May 19, 2023
@aviatesk
follow up #49812, fix the wrong type declaration (#49854)
e389ee2 
#49812 introduced a bug and broke the CI.
This commit fixes it up.

(cherry picked from commit 869c70e)
KristofferC pushed a commit that referenced this pull request May 27, 2023
@aviatesk @KristofferC
follow up #49812, fix the wrong type declaration (#49854)
c3458d0 
#49812 introduced a bug and broke the CI.
This commit fixes it up.

(cherry picked from commit 869c70e)
@KristofferC KristofferC removed the backport 1.9 Change should be backported to release-1.9 label May 28, 2023
kpamnany pushed a commit that referenced this pull request Jun 21, 2023
@aviatesk @kpamnany
follow up #49812, fix the wrong type declaration (#49854)
af29371 
#49812 introduced a bug and broke the CI.
This commit fixes it up.

(cherry picked from commit 869c70e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vtjnash vtjnash vtjnash approved these changes

Assignees

No one assigned

Labels

embarrassing-bugfix Whoops!

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@aviatesk @vtjnash @KristofferC @oscardssmith