Fix subtyping freeze in 1.9.0 #49875
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
N5N3
approved these changes
May 18, 2023
|
@AzamatB: merging this will reintroduce the subtype error you reported in #40865 to Julia 1.9.1. However it will remain fixed on 1.9.0 and on @KristofferC: can this go to 1.9.1? |
kpamnany
commented
May 18, 2023
|
Those are present on the backport branch as well. |
kpamnany
force-pushed
the
kp/fix-49857-take2
branch
from
84d8fdd to
2dcb8f0
Compare
|
Remaining failures seem to be the same ones as in |
kpamnany
added a commit
to RelationalAI/julia
that referenced
this pull request
May 22, 2023
* Disable slow path to handle Union explosion * 3 tests are broken due to disabling slow path
|
Glad to see this merged. Great work everyone! Thanks @N5N3, @kpamnany, @KristofferC! :) |
KristofferC
pushed a commit
that referenced
this pull request
May 27, 2023
* Disable slow path to handle Union explosion * 3 tests are broken due to disabling slow path
kpamnany
added a commit
that referenced
this pull request
Jun 21, 2023
* Disable slow path to handle Union explosion * 3 tests are broken due to disabling slow path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #49857.
As suggested by @N5N3, this disables the slow path in
local_forall_exists_subtypeas an alternative to backing out #48441.Confirmed that it fixes #49857. Also confirmed that the test added in #49014 passes. However, as with #49859, this fix will reopen #40865.
Cc: @quinnj and @NHDaly