Skip to content

only check that values are finite in generic_lufact when check=true #50525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 13, 2023
Merged

only check that values are finite in generic_lufact when check=true #50525

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1c71fda
only check that values are finite when check=true
Jul 12, 2023
bfbff0f
add tests
Jul 12, 2023
6ef6a0c
typo
oscardssmith Jul 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion stdlib/LinearAlgebra/src/lu.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ lu!(A::AbstractMatrix, pivot::Union{RowMaximum,NoPivot,RowNonZero} = lupivottype
generic_lufact!(A, pivot; check = check)
function generic_lufact!(A::AbstractMatrix{T}, pivot::Union{RowMaximum,NoPivot,RowNonZero} = lupivottype(T);
check::Bool = true) where {T}
LAPACK.chkfinite(A)
check && LAPACK.chkfinite(A)
# Extract values
m, n = size(A)
minmn = min(m,n)
Expand Down
7 changes: 7 additions & 0 deletions stdlib/LinearAlgebra/test/lu.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -464,4 +464,11 @@ end
@test Matrix(F1) ≈ Matrix(F2) ≈ C
end

@testset "matrix with Nonfinite" begin
lu(fill(NaN, 2, 2), check=false)
lu(fill(Inf, 2, 2), check=false)
LinearAlgebra.generic_lufact!(fill(NaN, 2, 2), check=false)
LinearAlgebra.generic_lufact!(fill(Inf, 2, 2), check=false)
end

end # module TestLU