Skip to content

gc: remove over-eager assertion #50540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 13, 2023
Merged

gc: remove over-eager assertion #50540

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/gf.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1483,7 +1483,7 @@ static int get_intersect_visitor(jl_typemap_entry_t *oldentry, struct typemap_in
struct matches_env *closure = container_of(closure0, struct matches_env, match);
assert(oldentry != closure->newentry && "entry already added");
assert(oldentry->min_world <= closure->newentry->min_world && "old method cannot be newer than new method");
assert(oldentry->max_world == ~(size_t)0 && "method cannot be added at the same time as method deleted");
assert(oldentry->max_world != closure->newentry->min_world && "method cannot be added at the same time as method deleted");
// don't need to consider other similar methods if this oldentry will always fully intersect with them and dominates all of them
typemap_slurp_search(oldentry, &closure->match);
jl_method_t *oldmethod = oldentry->func.method;
Expand Down