add delete for key[s] in a NamedTuple
#51098
Conversation
|
See also #46453 for a more general PR - includes delete(namedtuple) and more. Looks like implementations are somewhat different, which one is "better"? |
base/namedtuple.jl
Outdated
| (a = 1,) | ||
| ``` | ||
| """ | ||
| function delete(a::NamedTuple{an}, @nospecialize(key::Symbol)) where {an} |
There was a problem hiding this comment.
Why is there no specialize on key::Symbol?
There was a problem hiding this comment.
Thank you. I am removing it.
| NamedTuple{names}(a) | ||
| end | ||
|
|
||
| function delete(a::NamedTuple{an}, @nospecialize(keys::Tuple{Vararg{Symbol}})) where {an} |
There was a problem hiding this comment.
I know it's a pain, but there should probably be a serious conversation concerning when tuples of indices are used and how they're interpreted. We have tuples of indices for a single index on multidim arrays, but how should we refer to multiple indices on tuples and named tuples? There's a loss of information if we require it always be another subtype of AbstractArray
|
|
||
| export | ||
| # Modules | ||
| # Modules |
There was a problem hiding this comment.
Please do not change formatting unecessarily
There was a problem hiding this comment.
that was unintentional -- thank you for catching the mistype
|
the test failures do not involve namedtuples.jl |
|
This PR introduces experimental |
brenhinkeller
added
the
collections
|
This has many accidental formatting changes. No matter; the old version of the PR is just fine and we can merge that (it needs to be re-created though). |
8 participants
Replaces #27725
This PR updates delete for NamedTuples. See that (closed) PR for much discussion. This revision supports deleting one or more keys from a NamedTuple.