Excise FileWatching by moving pidfile to Base #51463
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am slowly redefining what it means to be a stdlib.
Previously we have used stdlibs as a way to organize code,
outside the monolith that is
base/. With a move towardsstdlibs using pkgimages as their caching mechanism and them
becoming upgradeable, we have to redefine the relationship
between Base and stdlibs.
In my opinion Base should not have a direct dependency on
functionality in standard libraries. If we need something to be used by Base,
we must include the minimal set of functionality.
Functions in Base should either be universally useful,
or require some sort of compiler/runtime support.
Since we are not breaking functionality we must allow for
auto-loading/delayed loading of packages, but that mechanism,
must allow for the loading to fail.
Pidfile support was introduced in #44367, but it only uses
a
watch_filefrom FileWatching.jl.Here I moved pidfile.jl to base, removing the usage of FileWatching.
I decided against delayed initialization, since there would be a
rather annoying recusrion potential, and we don't want users to
disallow
@stdliband then suddenly have cache races again.