Skip to content

Conversation

@fatteneder
Copy link
Member

@fatteneder fatteneder commented Oct 20, 2023

Continuation of #49866.
Fixes #52462

So far any include_dependency was tracked by mtime.
A package using include_dependency can't be relocated without recompilation if the dependency also needs to be relocated.

With include_dependency(path, track_content=true) the tracking works like for include,
i.e. recompilation is only triggered when the file's content changes.
In case path is a directory we use the string join(readdir(path)) as content.

@fatteneder fatteneder added the compiler:precompilation Precompilation of modules label Oct 20, 2023
@fatteneder
Copy link
Member Author

Need to add a Julia compat note to docs.

@DilumAluthge DilumAluthge added needs compat annotation Add !!! compat "Julia x.y" to the docstring packages Package management and loading modules labels Oct 22, 2023
@fatteneder fatteneder marked this pull request as draft October 24, 2023 21:17
@fatteneder fatteneder force-pushed the fa/incl-deps-track-content branch from c35908f to 01d0b4d Compare October 29, 2023 01:00
@fatteneder fatteneder removed the needs compat annotation Add !!! compat "Julia x.y" to the docstring label Oct 29, 2023
@fatteneder fatteneder marked this pull request as ready for review October 29, 2023 01:01
@fatteneder fatteneder force-pushed the fa/incl-deps-track-content branch from 01d0b4d to 54421ed Compare October 29, 2023 01:01
@vchuravy vchuravy added this to the 1.11 milestone Nov 4, 2023
@fatteneder fatteneder force-pushed the fa/incl-deps-track-content branch from 174f65a to e7c171e Compare December 9, 2023 19:29
@fatteneder fatteneder force-pushed the fa/incl-deps-track-content branch from 606c535 to 0554073 Compare February 2, 2024 11:25
@fatteneder
Copy link
Member Author

After rebasing there is now a test failure that seems related to #53103.
Need to look into that.

@KristofferC KristofferC merged commit b5bd10e into JuliaLang:master Feb 8, 2024
@fatteneder fatteneder deleted the fa/incl-deps-track-content branch February 8, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

compiler:precompilation Precompilation of modules modules packages Package management and loading

Projects

None yet

Development

Successfully merging this pull request may close these issues.

include()'ing nonexistant file now gives misleading "can only hash files" error

7 participants