Integer matrix exponentiation in schurpow #51992
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves type-inference by avoiding recursion, as the
A^pmethod callsschurpowifpis a float. After this, the result ofschurpowis inferred as a smallUnion:One concern here might be that for large
p, theA^Int(p)computation might be expensive by repeated multiplication, as opposed to diagonalization. However, this may only be the case for really largep, which may not be commonly encountered.I've added a test, but I'm unsure if
schurpowis deemed to be an internal function, and this test is unwise. Unfortunately, the return type ofA^pisn't concretely inferred yet as there are too many possible types that are returned, so I couldn't test for that.