Remove unnecessary check in Memory creation #52068
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
reviewed
Nov 7, 2023
|
|
||
| # type and dimensionality specified | ||
| (self::Type{GenericMemory{kind,T,addrspace}})(::UndefInitializer, m::Int) where {T,addrspace,kind} = | ||
| if isdefined(self, :instance) && m === 0 |
Member
There was a problem hiding this comment.
This needs some supporting performance analysis, since it hardly even appears in the IR after optimization
julia> code_typed(Memory{Int}, (Core.UndefInitializer, Int))
1-element Vector{Any}:
CodeInfo(
1 ─ nothing::Nothing
│ @ boot.jl:498 within `GenericMemory`
│ %2 = (m === 0)::Bool
└── goto #3 if not %2
@ boot.jl:500 within `GenericMemory`
2 ─ %4 = Core.getproperty(self, :instance)::Memory{Int64}
└── return %4
@ boot.jl:502 within `GenericMemory`
3 ─ %6 = $(Expr(:foreigncall, :(:jl_alloc_genericmemory), Ref{GenericMemory{kind, T, addrspace}}, svec(Any, Int64), 0, :(:ccall), Core.Argument(1), Core.Argument(3), Core.Argument(3)))::Memory{Int64}
└── return %6
) => Memory{Int64}
Member
Author
There was a problem hiding this comment.
The entire thing is in the IR.
Member
|
@nanosoldier |
Collaborator
|
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. |
Member
|
@nanosoldier |
Collaborator
|
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. |
Member
|
Looks like one 6X reduction and no improvements? |
Member
|
I see quite a few improvements? |
Member
|
I might have missed it, since I scroll pretty fast usually. Which one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.