Update probes.md to remove workaround #53160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given JuliaLang#41616 merged I assume this workaround can be removed. I haven't tested it.
vchuravy
reviewed
Feb 2, 2024
Member
|
I don't think we should remove this. The general problem holds since we don't have safepoints on loop backedges. |
Member
|
Right replacing fib with a function that inlines will cause the same behaviour as before. |
vtjnash
approved these changes
Feb 10, 2024
Member
vtjnash
left a comment
vtjnash
left a comment
There was a problem hiding this comment.
Eventually it may be redundant, but it should never be harmful
inkydragon
reviewed
Feb 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given #41616 merged I assume this workaround can be removed. I haven't tested it.