fix rare GC segfault coming from bug in mark-loop termination protocal #53351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-netto
force-pushed
the
dcn-fix-rare-gc-segfault
branch
from
85f9098 to
119019a
Compare
d-netto
force-pushed
the
dcn-fix-rare-gc-segfault
branch
from
119019a to
84fed22
Compare
|
How does this fix the first 2? |
|
This implementation is way too awkward. Will close it for now and supersede it by #53353. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #52757, #53026 and #53350.
This code got fairly awkward after this change, particularly because we must be able to handle straggler threads that try to join the mark-loop a long time after it has finished.
Open to suggestions on whether we should do a more significant refactor here to prevent this case from happening in the first place.