Skip to content

Fix Cthulhu.jl#541 by catching IOError when calling REPL.Terminals.raw! #53392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix Cthulhu.jl#541 by catching IOError when calling REPL.Terminals.raw! #53392

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion stdlib/REPL/src/TerminalMenus/AbstractMenu.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,14 @@ function request(term::REPL.Terminals.TTYTerminal, m::AbstractMenu; cursor::Unio
finally # always disable raw mode
if raw_mode_enabled
!suppress_output && print(term.out_stream, "\x1b[?25h") # unhide cursor
REPL.Terminals.raw!(term, false)
try
# raw! calls check_open which can throw
REPL.Terminals.raw!(term, false)
catch err
if err !== Base.IOError("stream is closed or unusable", 0)
rethrow()
end
end
end
end
!suppress_output && println(term.out_stream)
Expand Down