Skip to content

precompilepkgs: package in boths deps and weakdeps are in fact only weak #53649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 8, 2024
Merged

precompilepkgs: package in boths deps and weakdeps are in fact only weak #53649

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions base/precompilation.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,9 @@ struct ExplicitEnv
end

function ExplicitEnv(envpath::String=Base.active_project())
if !isfile(envpath)
error("expected a project file at $(repr(envpath))")
end
envpath = abspath(envpath)
project_d = parsed_toml(envpath)

Expand All @@ -51,6 +54,11 @@ function ExplicitEnv(envpath::String=Base.active_project())
end
end

# A package in both deps and weakdeps is in fact only a weakdep
for (name, _) in project_weakdeps
delete!(project_deps, name)
end

project_extensions = Dict{String, Vector{UUID}}()
# Collect all extensions of the project
for (name, triggers::Union{String, Vector{String}}) in get(Dict{String, Any}, project_d, "extensions")::Dict{String, Any}
Expand Down