NFC: rename pool_alloc to make the naming a bit more compatible with other GC impls #55207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
CC: @fingolfin. I don't think this breaks anything in Oscar et al., but please let me know if it's not the case. |
d-netto
force-pushed
the
dcn-rename-pool-alloc
branch
2 times, most recently
from
ac3abbf to
1787c81
Compare
kpamnany
reviewed
Jul 22, 2024
Member
kpamnany
left a comment
kpamnany
left a comment
There was a problem hiding this comment.
Feels like there's more to be done in this PR -- I've commented on a few additional changes that I think would be good to have. I'm a little concerned that we might have inconsistencies in the codebase with a partial change. Interested to see other reviews.
d-netto
force-pushed
the
dcn-rename-pool-alloc
branch
4 times, most recently
from
46ab7a2 to
1c22b75
Compare
d-netto
force-pushed
the
dcn-rename-pool-alloc
branch
from
1c22b75 to
a3c8cfa
Compare
fingolfin
approved these changes
Jul 22, 2024
gbaraldi
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other GC implementations may not want to necessarily segregate small objects into object pools (e.g. may just want to allocate everything with Libc malloc).
Let's rename
pool_alloctosmall_allocto make it a bit more general in the sense that although we're exposing different allocation functions, we make no mention to the fact that they're using object pools under the hood.