Skip to content

Fix tr for block SymTridiagonal #55371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2024
Merged

Fix tr for block SymTridiagonal #55371

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion stdlib/LinearAlgebra/src/tridiag.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ Base.copy(S::Adjoint{<:Any,<:SymTridiagonal}) = SymTridiagonal(map(x -> copy.(ad
ishermitian(S::SymTridiagonal) = isreal(S.dv) && isreal(_evview(S))
issymmetric(S::SymTridiagonal) = true

tr(S::SymTridiagonal) = sum(S.dv)
tr(S::SymTridiagonal) = sum(symmetric, S.dv)

@noinline function throw_diag_outofboundserror(n, sz)
sz1, sz2 = sz
Expand Down
5 changes: 4 additions & 1 deletion stdlib/LinearAlgebra/test/tridiag.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -471,7 +471,7 @@ end
end

@testset "SymTridiagonal/Tridiagonal block matrix" begin
M = [1 2; 2 4]
M = [1 2; 3 4]
n = 5
A = SymTridiagonal(fill(M, n), fill(M, n-1))
@test @inferred A[1,1] == Symmetric(M)
Expand All @@ -485,6 +485,9 @@ end
@test_throws ArgumentError diag(A, n+1)
@test_throws ArgumentError diag(A, -n-1)

@test tr(A) == sum(diag(A))
@test issymmetric(tr(A))

A = Tridiagonal(fill(M, n-1), fill(M, n), fill(M, n-1))
@test @inferred A[1,1] == M
@test @inferred A[1,2] == M
Expand Down