Skip to content

Conversation

@gbaraldi
Copy link
Member

No description provided.

@vtjnash vtjnash added multithreading Base.Threads and related functionality merge me PR is reviewed. Merge when all tests are passing labels Aug 15, 2024
@giordano
Copy link
Member

https://buildkite.com/julialang/julia-master/builds/39245#019157be-da72-4fb0-9294-7835a6bdcbff/830-1686

Error in testset Serialization:
Error During Test at /Users/julia/.julia/scratchspaces/a66863c6-20e8-4ff4-8a62-49f30b1f605e/agent-cache/default-honeycrisp-HL2F7YQ3XH.0/build/default-honeycrisp-HL2F7YQ3XH-0/julialang/julia-master/julia-3eb9ab3e1c/share/julia/test/testdefs.jl:24
  Got exception outside of a @test
  LoadError: ConcurrencyViolationError("setfield!: atomic field cannot be written non-atomically")
  Stacktrace:
    [1] setproperty!
      @ ./Base.jl:53 [inlined]
    [2] setproperty!
      @ ./task.jl:193 [inlined]
    [3] deserialize(s::Serializer{IOBuffer}, ::Type{Task})
      @ Serialization /Users/julia/.julia/scratchspaces/a66863c6-20e8-4ff4-8a62-49f30b1f605e/agent-cache/default-honeycrisp-HL2F7YQ3XH.0/build/default-honeycrisp-HL2F7YQ3XH-0/julialang/julia-master/julia-3eb9ab3e1c/share/julia/stdlib/v1.12/Serialization/src/Serialization.jl:1575

looks relevant

@vchuravy
Copy link
Member

Fixes #55125 (comment)

See #55125 in general for which tests to update. I think you need to simply adjust the serialization code to also use an atomic here.

@gbaraldi
Copy link
Member Author

Looking at the uses of _state most are unordered atomics so I won't change them. But they might deserve a look

@giordano
Copy link
Member

I presume this is good to go?

@gbaraldi gbaraldi merged commit f2f76d8 into master Aug 20, 2024
@gbaraldi gbaraldi deleted the gb/stateatomic branch August 20, 2024 17:39
@giordano giordano removed the merge me PR is reviewed. Merge when all tests are passing label Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

multithreading Base.Threads and related functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants