Skip to content

Conversation

@fatteneder
Copy link
Member

Implements the idea from #54138 (comment).

A follow-up PR would apply it to some relevant functions in Base.

@fatteneder fatteneder requested a review from vtjnash October 13, 2024 17:56
@nsajko nsajko added the feature Indicates new feature / enhancement requests label Oct 15, 2024
Copy link
Member

@ararslan ararslan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could be nice to have analogous functionality for unsealing a method table as well.

@fatteneder fatteneder changed the title Allow sealing of Core.MethodTables Allow freezing of Core.MethodTables Oct 17, 2024
@fatteneder
Copy link
Member Author

i guess the analyzegc failure is due to me not being familiar with atomics ordering, will check tomorrow

Copy link
Member

@vtjnash vtjnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM, but would probably be good to hear from @JeffBezanson or @Keno or triage if they have thoughts about the API here? The gc-analyzer looks like you can fix it by adding assert(mt != NULL) there. I don't really know why it is triggering from this, but that should make it happy

There is also a core test that needs to be fixed (adding this field to the list of atomic fields)

@fatteneder
Copy link
Member Author

The gc-analyzer looks like you can fix it by adding assert(mt != NULL) there. I don't really know why it is triggering from this, but that should make it happy

Thanks, that fixed it it locally. I could not make sense out of this either.

@nsajko nsajko added types and dispatch Types, subtyping and method dispatch status: waiting for PR author labels Jun 5, 2025
@nsajko
Copy link
Member

nsajko commented Jun 5, 2025

This branch has conflicts that must be resolved

@vtjnash
Copy link
Member

vtjnash commented Oct 15, 2025

The feature may still be interesting, but the implementation details this relied on no longer exist, so there wouldn't be any way to rebase this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature Indicates new feature / enhancement requests types and dispatch Types, subtyping and method dispatch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants