Skip to content

Make a failed extension load throw an error during pre-compilation #56668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 28, 2024
Merged

Make a failed extension load throw an error during pre-compilation #56668

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab49cee
Make extension loading failure throw an error during pre-compilation
topolarity Nov 24, 2024
3164bd9
Update base/loading.jl
topolarity Nov 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions base/loading.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1585,9 +1585,14 @@ function run_extension_callbacks(extid::ExtensionId)
true
catch
# Try to continue loading if loading an extension errors
errs = current_exceptions()
@error "Error during loading of extension $(extid.id.name) of $(extid.parentid.name), \
if JLOptions().incremental != 0
# during incremental precompilation, this should be fail-fast
rethrow()
else
errs = current_exceptions()
@error "Error during loading of extension $(extid.id.name) of $(extid.parentid.name), \
use `Base.retry_load_extensions()` to retry." exception=errs
end
false
finally
global loading_extension = false
Expand Down