Skip to content

Export opaque closure constructor #56808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Export opaque closure constructor #56808

wants to merge 1 commit into from

Conversation

@wsmoses
Copy link
Member

@wsmoses wsmoses commented Dec 12, 2024

No description provided.

@wsmoses wsmoses added backport 1.10 Change should be backported to the 1.10 release backport 1.11 Change should be backported to release-1.11 labels Dec 12, 2024
topolarity
topolarity reviewed Dec 12, 2024
View reviewed changes
Copy link
Member

@topolarity topolarity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs an entry in jl_exported_funcs.inc too, right?
(it looks like jl_new_opaque_closure_from_code_info is also missing from there)

@topolarity topolarity requested a review from Keno December 12, 2024 13:51
vtjnash
vtjnash requested changes Dec 12, 2024
View reviewed changes
Copy link
Member

@vtjnash vtjnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The external API is Expr(:new_opaque_closure). This function is private

This was referenced Dec 13, 2024
Merged
Merged
@wsmoses
Copy link
Member Author

wsmoses commented Dec 14, 2024

So there was a expression lexing? error with the expression form I mentioned to keno on slack that I had run into. But in any case fair enough, closng (and will make an alternate solution).

@wsmoses wsmoses removed backport 1.10 Change should be backported to the 1.10 release backport 1.11 Change should be backported to release-1.11 labels Dec 14, 2024
@wsmoses wsmoses mentioned this pull request Dec 14, 2024
Merged
oscardssmith added a commit that referenced this pull request Sep 16, 2025
@oscardssmith
Make version of opaque closure constructor in world (#56823)
e46cc1a 
Successor to #56808 which enables
an opaque closure to be constructed with a specified world age (if, for
example, the current world age isn't valid due to being in a generated
function). Required for EnzymeAD/Reactant.jl#365
KristofferC pushed a commit that referenced this pull request Sep 17, 2025
@oscardssmith
Make version of opaque closure constructor in world (#56823)
27507d6 
Successor to #56808 which enables
an opaque closure to be constructed with a specified world age (if, for
example, the current world age isn't valid due to being in a generated
function). Required for EnzymeAD/Reactant.jl#365

(cherry picked from commit e46cc1a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@topolarity topolarity topolarity left review comments

@vtjnash vtjnash vtjnash requested changes

@Keno Keno Awaiting requested review from Keno

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wsmoses @vtjnash @topolarity