Skip to content

typeinfer: Enqueue CIs for ccallable entrypoints #57158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 28, 2025
Merged

typeinfer: Enqueue CIs for ccallable entrypoints #57158

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a59a917
typeinfer: Enqueue CIs for `ccallable` entrypoints
topolarity Jan 24, 2025
f650383
Update Compiler/src/typeinfer.jl
topolarity Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions Compiler/src/typeinfer.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1280,8 +1280,20 @@ function typeinf_ext_toplevel(methods::Vector{Any}, worlds::Vector{UInt}, trim::
ci isa CodeInstance && !use_const_api(ci) && push!(tocompile, ci)
end
elseif item isa SimpleVector
push!(codeinfos, item[1]::Type)
push!(codeinfos, item[2]::Type)
(rt::Type, sig::Type) = item
# make a best-effort attempt to enqueue the relevant code for the ccallable
ptr = ccall(:jl_get_specialization1,
#= MethodInstance =# Ptr{Cvoid}, (Any, Csize_t, Cint),
sig, this_world, #= mt_cache =# 0)
if ptr !== C_NULL
mi = unsafe_pointer_to_objref(ptr)
ci = typeinf_ext(interp, mi, SOURCE_MODE_NOT_REQUIRED)
ci isa CodeInstance && !use_const_api(ci) && push!(tocompile, ci)
end
# additionally enqueue the ccallable entrypoint / adapter, which implicitly
# invokes the above ci
push!(codeinfos, rt)
push!(codeinfos, sig)
end
end
while !isempty(tocompile)
Expand Down
Loading