-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
update path to Compiler stdlib to a valid one similar to how it is done for other stdlibs #57274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32 tasks
7215684 to
157774c
Compare
KristofferC
commented
Feb 7, 2025
base/methodshow.jl
Outdated
| path = npath == npath′ ? path : npath′ | ||
| end | ||
| if isdefined(@__MODULE__, :Core) && isdefined(Core, :Compiler) | ||
| compiler_folder = dirname(string(methods(Core.Compiler.eval)[1].file)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Keno, do you have a more aesthetically pleasing way to do this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, there is #55963.
KristofferC
added a commit
to KristofferC/CodeTracking.jl
that referenced
this pull request
Mar 21, 2025
This allows us to automatically get new functionality like JuliaLang/julia#57274.
KristofferC
added a commit
to JuliaDebug/CodeTracking.jl
that referenced
this pull request
Apr 2, 2025
This allows us to automatically get new functionality like JuliaLang/julia#57274.
KristofferC
added a commit
to KristofferC/CodeTracking.jl
that referenced
this pull request
Apr 16, 2025
This allows us to automatically get new functionality like JuliaLang/julia#57274.
mhauru
added a commit
to mhauru/Mooncake.jl
that referenced
this pull request
Oct 23, 2025
This comes up because in Julia 1.12 logmsg_code gets the folder of Core.Compiler if needed to resolve paths, which results in a ccall with no known rule. See JuliaLang/julia#57274.
yebai
pushed a commit
to chalk-lab/Mooncake.jl
that referenced
this pull request
Oct 23, 2025
* Mark Base.fixup_stdlib_path as having @zero_derivative This comes up because in Julia 1.12 logmsg_code gets the folder of Core.Compiler if needed to resolve paths, which results in a ccall with no known rule. See JuliaLang/julia#57274. * Make Base.CoreLogging.handle_message_nothrow as having @zero_derivative This comes up in logmsg_code, because in Julia v1.12 handle_message_nothrow got a try-catch structure, which creates an UpsilonNode that Mooncake can't handle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #56865. The Compiler "stdlib" resides in a different location so the current logic didn't handle updating it.
The
line to figure out the build path to the compiler feels very ugly. It is also something that is constant so doing it every time is wasteful...