codegen: cleanup gcstack call frames somewhat earlier #57410
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
added
compiler:codegen
|
I noticed this on #57380 and thought we could just make it unconditional, the check doesn't save much but implemented it anyway if you want to keep it |
|
That doesn't look sound (this same bug), so I don't think we want that |
|
Oh, I see, that is just for final-lowering, deciding if the module contains anything we could lower. I think you'd need to add a |
Slightly reduces the amount of work these optimization passes need to do later, in most typical cases, and avoids putting an unknown call at the top of all of our functions, which can inhibit some optimizations of otherwise trivial functions. Fixes #57400
vtjnash
force-pushed
the
jn/lost-gcframe
branch
from
7e7f74f to
7ff7964
Compare
|
Doesn't backport cleanly so some help with that would be appreciated. |
This was referenced Mar 24, 2025
51 tasks
53 tasks
58 tasks
This was referenced Sep 15, 2025
This was referenced Sep 24, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slightly reduces the amount of work these optimization passes need to do later, in most typical cases, and avoids putting an unknown call at the top of all of our functions, which can inhibit some optimizations of otherwise trivial functions.
Fixes #57400