Add missing arg in TOML printvalue
#57584
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise error when calling `print_inline_table`
KristofferC
added
backport 1.10
|
A test would be good |
|
|
||
| if a in inline_tables | ||
| @invokelatest print_inline_table(f, io, a) | ||
| @invokelatest print_inline_table(f, io, a, sorted) |
There was a problem hiding this comment.
I tested locally and this fix isn't covered by tests.
There was a problem hiding this comment.
OK added another test for this
IanButterworth
added
the
merge me
IanButterworth
approved these changes
Mar 5, 2025
KristofferC
pushed a commit
that referenced
this pull request
Mar 11, 2025
Otherwise error when calling `print_inline_table` (cherry picked from commit f207224)
This was referenced Mar 11, 2025
Merged
KristofferC
pushed a commit
that referenced
this pull request
Mar 20, 2025
Otherwise error when calling `print_inline_table` (cherry picked from commit f207224)
KristofferC
removed
the
backport 1.12
KristofferC
pushed a commit
that referenced
this pull request
Mar 25, 2025
Otherwise error when calling `print_inline_table` (cherry picked from commit f207224)
qiaojunfeng
added a commit
to qiaojunfeng/WannierIO.jl
that referenced
this pull request
Mar 28, 2025
Since `write_toml` requires PR JuliaLang/julia#57584
qiaojunfeng
added a commit
to qiaojunfeng/WannierIO.jl
that referenced
this pull request
Mar 28, 2025
Since `write_toml` requires PR JuliaLang/julia#57584
qiaojunfeng
added a commit
to qiaojunfeng/WannierIO.jl
that referenced
this pull request
Mar 28, 2025
Since `write_toml` requires PR JuliaLang/julia#57584
KristofferC
removed
the
backport 1.11
KristofferC
removed
the
backport 1.10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise error when calling
print_inline_table