-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
CI: Store Passes in results.json + various improvements. #57686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Store Passes in results.json + various improvements. #57686
Conversation
95328b4 to
96ec737
Compare
e5cabc0 to
149657f
Compare
Can you expand on this a little bit? |
|
Currently we report that a test takes the duration of its parent testset. So |
|
Oh yeah, that's silly. Can we capture useful duration times? |
|
Our |
bcc4cf0 to
03861bb
Compare
|
It seems like dropping the value from the Pass does help memory usage but the weakref test is failing again. I guess that test just was dependent on the Pass object with the value captured being freed immediately and this somehow slightly delays it. Also, it seems like bk considers tests with 0.0 duration to not have run.. these last few runs report no tests, so I think I'll just set all tests to 1.0 duration. |
f7ec9f6 to
9bc0a07
Compare
|
Hitting a buildkite issue: https://forum.buildkite.community/t/test-failures-showing-up-in-test-digest-but-not-on-jobs/4306 (buildkite are looking into it) |
86829c5 to
1290873
Compare
results.json30e0684 to
991ed5a
Compare
also rm tags we now set during upload see JuliaCI/julia-buildkite#435
991ed5a to
4e2c472
Compare
|
@IanButterworth I think that one of your test fixes in this PR will help me fix CI on the 1.11 backports PR (#59336). Specifically, the tempname fixes to Would you recommend that I backport this entire PR to 1.11? Or should I backport only the single commit that I need (7c81745)? (I don't know enough about the background of this PR to know if it would be acceptable to backport.) |
Note on the WeakRef test fix: If a test like
@test x == ypasses, thePassobject retainsx. Previously to this the Pass object was still made, but must have been GC-ed immediately. This PR remakes the Pass object when appending it to DefaultTestSet without the captured data. I think that just delayed the GC a little to make the test flaky, so I moved the@testto outside the function to avoid capturingx.Also buildkite had to fix an issue to make tests show up properly on our jobs:
https://forum.buildkite.community/t/test-failures-showing-up-in-test-digest-but-not-on-jobs/4306