Add right arrow and end as completion keys #57746
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Octogonapus
force-pushed
the
extra_completion_keys
branch
from
4e2b095 to
663007d
Compare
|
I think this is related but different to #57273 right? |
IanButterworth
added
REPL
|
Oh I wasn't familiar with that work because I've never seen this behavior work in Julia before. I'll review that stuff later. |
|
Ok after review, I've merged up my work with those changes. This PR builds on top of it. Updated the PR description. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the feature added in #54983 by allowing it to work when there is more than one completion (allowing you to always accept the autosuggestion) and adds
Endas another completion key.This PR also centralizes the places where completions are managed, rather than in #54983 which split them up.
As in #54983, these two keys only accept completions when there is an autosuggestion presented (the gray text after what you have already typed). Pressing these keys repeatedly won't show a list of completions,
which matches the behavior of similar tools from other environments. These keys are the defaults for other autosuggestions tools I have used like zsh-autosuggestions
and fish shell. For users of zsh and fish, this is a more natural setup.