Skip to content

Profile: remove scope from profile macros #57858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 25, 2025
Merged

Profile: remove scope from profile macros #57858

merged 2 commits into from
Mar 25, 2025

Conversation

IanButterworth
Copy link
Member

@IanButterworth IanButterworth commented Mar 21, 2025 •
edited
Loading

Fixes this, which breaks expectations from the way @time doesn't introduce a new scope.

julia> using Profile

julia> @profile x = 1
1

julia> x
ERROR: UndefVarError: `x` not defined in `Main`
Suggestion: check for spelling errors or missing imports.

@IanButterworth IanButterworth added profiler backport 1.10 Change should be backported to the 1.10 release backport 1.11 Change should be backported to release-1.11 backport 1.12 Change should be backported to release-1.12 labels Mar 21, 2025
This was referenced Mar 22, 2025
Merged
Merged
@KristofferC KristofferC merged commit d6af199 into JuliaLang:master Mar 25, 2025
5 of 7 checks passed
@IanButterworth IanButterworth deleted the ib/profile_noscope branch March 25, 2025 13:36
KristofferC pushed a commit that referenced this pull request Mar 26, 2025
@IanButterworth @KristofferC
Profile: remove scope from profile macros (#57858)
da85988 
Fixes this, which breaks expectations from the way `@time` doesn't
introduce a new scope.
```
julia> using Profile

julia> @Profile x = 1
1

julia> x
ERROR: UndefVarError: `x` not defined in `Main`
Suggestion: check for spelling errors or missing imports.
```

(cherry picked from commit d6af199)
@KristofferC KristofferC removed the backport 1.12 Change should be backported to release-1.12 label Mar 31, 2025
@KristofferC KristofferC mentioned this pull request Mar 31, 2025
Merged
71 tasks
KristofferC pushed a commit that referenced this pull request Mar 31, 2025
@IanButterworth @KristofferC
Profile: remove scope from profile macros (#57858)
7dc1c66 
Fixes this, which breaks expectations from the way `@time` doesn't
introduce a new scope.
```
julia> using Profile

julia> @Profile x = 1
1

julia> x
ERROR: UndefVarError: `x` not defined in `Main`
Suggestion: check for spelling errors or missing imports.
```

(cherry picked from commit d6af199)
KristofferC pushed a commit that referenced this pull request Mar 31, 2025
@IanButterworth @KristofferC
Profile: remove scope from profile macros (#57858)
58f4699 
Fixes this, which breaks expectations from the way `@time` doesn't
introduce a new scope.
```
julia> using Profile

julia> @Profile x = 1
1

julia> x
ERROR: UndefVarError: `x` not defined in `Main`
Suggestion: check for spelling errors or missing imports.
```

(cherry picked from commit d6af199)
KristofferC pushed a commit that referenced this pull request Mar 31, 2025
@IanButterworth @KristofferC
Profile: remove scope from profile macros (#57858)
0819f97 
Fixes this, which breaks expectations from the way `@time` doesn't
introduce a new scope.
```
julia> using Profile

julia> @Profile x = 1
1

julia> x
ERROR: UndefVarError: `x` not defined in `Main`
Suggestion: check for spelling errors or missing imports.
```

(cherry picked from commit d6af199)
@KristofferC KristofferC removed the backport 1.11 Change should be backported to release-1.11 label Apr 10, 2025
@KristofferC KristofferC mentioned this pull request Jun 4, 2025
Merged
75 tasks
KristofferC pushed a commit that referenced this pull request Jun 5, 2025
@IanButterworth @KristofferC
Profile: remove scope from profile macros (#57858)
2fbe680 
Fixes this, which breaks expectations from the way `@time` doesn't
introduce a new scope.
```
julia> using Profile

julia> @Profile x = 1
1

julia> x
ERROR: UndefVarError: `x` not defined in `Main`
Suggestion: check for spelling errors or missing imports.
```

(cherry picked from commit d6af199)
KristofferC pushed a commit that referenced this pull request Jun 5, 2025
@IanButterworth @KristofferC
Profile: remove scope from profile macros (#57858)
e4d13dc 
Fixes this, which breaks expectations from the way `@time` doesn't
introduce a new scope.
```
julia> using Profile

julia> @Profile x = 1
1

julia> x
ERROR: UndefVarError: `x` not defined in `Main`
Suggestion: check for spelling errors or missing imports.
```

(cherry picked from commit d6af199)
KristofferC pushed a commit that referenced this pull request Jun 5, 2025
@IanButterworth @KristofferC
Profile: remove scope from profile macros (#57858)
e6d7b04 
Fixes this, which breaks expectations from the way `@time` doesn't
introduce a new scope.
```
julia> using Profile

julia> @Profile x = 1
1

julia> x
ERROR: UndefVarError: `x` not defined in `Main`
Suggestion: check for spelling errors or missing imports.
```

(cherry picked from commit d6af199)
KristofferC added a commit that referenced this pull request Jun 5, 2025
@KristofferC
fixup! Profile: remove scope from profile macros (#57858)
6d7bd65
KristofferC pushed a commit that referenced this pull request Jun 5, 2025
@IanButterworth @KristofferC
Profile: remove scope from profile macros (#57858)
67222f2 
Fixes this, which breaks expectations from the way `@time` doesn't
introduce a new scope.
```
julia> using Profile

julia> @Profile x = 1
1

julia> x
ERROR: UndefVarError: `x` not defined in `Main`
Suggestion: check for spelling errors or missing imports.
```

(cherry picked from commit d6af199)
KristofferC pushed a commit that referenced this pull request Jun 5, 2025
@IanButterworth @KristofferC
Profile: remove scope from profile macros (#57858)
967a256 
Fixes this, which breaks expectations from the way `@time` doesn't
introduce a new scope.
```
julia> using Profile

julia> @Profile x = 1
1

julia> x
ERROR: UndefVarError: `x` not defined in `Main`
Suggestion: check for spelling errors or missing imports.
```

(cherry picked from commit d6af199)
KristofferC pushed a commit that referenced this pull request Jul 3, 2025
@IanButterworth
Profile: remove scope from profile macros (#57858)
7965703 
Fixes this, which breaks expectations from the way `@time` doesn't
introduce a new scope.
```
julia> using Profile

julia> @Profile x = 1
1

julia> x
ERROR: UndefVarError: `x` not defined in `Main`
Suggestion: check for spelling errors or missing imports.
```

(cherry picked from commit d6af199)
@DilumAluthge DilumAluthge mentioned this pull request Sep 13, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

backport 1.10 Change should be backported to the 1.10 release profiler

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@IanButterworth @KristofferC