Skip to content

Remove try-finally scope from @time_imports @trace_compile @trace_dispatch #58011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 10, 2025
Merged

Remove try-finally scope from @time_imports @trace_compile @trace_dispatch #58011

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 18 additions & 15 deletions base/timing.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -643,33 +643,36 @@ end
# here so it's possible to time/trace all imports, including InteractiveUtils and its deps
macro time_imports(ex)
quote
try
Base.Threads.atomic_add!(Base.TIMING_IMPORTS, 1)
$(esc(ex))
finally
Base.Threads.atomic_add!(Base.TIMING_IMPORTS, 1)
@__tryfinally(
# try
$(esc(ex)),
# finally
Base.Threads.atomic_sub!(Base.TIMING_IMPORTS, 1)
end
)
end
end

macro trace_compile(ex)
quote
try
ccall(:jl_force_trace_compile_timing_enable, Cvoid, ())
$(esc(ex))
finally
ccall(:jl_force_trace_compile_timing_enable, Cvoid, ())
@__tryfinally(
# try
$(esc(ex)),
# finally
ccall(:jl_force_trace_compile_timing_disable, Cvoid, ())
end
)
end
end

macro trace_dispatch(ex)
quote
try
ccall(:jl_force_trace_dispatch_enable, Cvoid, ())
$(esc(ex))
finally
ccall(:jl_force_trace_dispatch_enable, Cvoid, ())
@__tryfinally(
# try
$(esc(ex)),
# finally
ccall(:jl_force_trace_dispatch_disable, Cvoid, ())
end
)
end
end