remove some more serialized junk from the sysimg #58078
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffBezanson
approved these changes
Apr 11, 2025
vtjnash
added
don't squash
After the bindings change, there is quite a lot of garbage in here now at runtime (it does not de-duplicate entries added for bindings), so attempt to do a bit of that during serialization.
Compressing IR adds Methods roots, which tend to become quite expensive to store after some time. We also used to store the inferred code, but since we never actually look at that again now (since now the compiler avoids using --output-ji or --sysimage-native-code=no or --pkgimages=no) it is now quite a bit of wasted space also. For some reason, this also generates 20% more native code in the system image, which isn't quite clear if that is good or not.
|
This seems to have caused a lot of test failures. |
aviatesk
pushed a commit
that referenced
this pull request
Apr 17, 2025
Revert #58078 as it broke CI extensively.
vtjnash
added a commit
that referenced
this pull request
Apr 20, 2025
After the bindings change, there is quite a lot of garbage in here now at runtime (it does not de-duplicate entries added for bindings), so attempt to do a bit of that during serialization. Re-landing part of #58078
53 tasks
serenity4
pushed a commit
to serenity4/julia
that referenced
this pull request
May 1, 2025
Together, the commits save roughly 184 MB -> 159 MB by not storing unnecessary inferred IR ``` $ llvm-size -A usr/lib/julia/sys.dylib usr/lib/julia/sys.dylib : section size addr __text 15522036 1904 __stubs 1128 15523940 __stub_helper 1152 15525068 __const 438592 15526224 __cstring 297006 15964816 __unwind_info 247368 16261824 __eh_frame 27144 16509192 __got 104 16547840 __const 632 16547944 __la_symbol_ptr 752 16564224 __data 142444216 16564992 __common 100800 159009216 Total 159080930 ```
serenity4
pushed a commit
to serenity4/julia
that referenced
this pull request
May 1, 2025
…58150) Revert JuliaLang#58078 as it broke CI extensively.
LebedevRI
pushed a commit
to LebedevRI/julia
that referenced
this pull request
May 2, 2025
…58150) Revert JuliaLang#58078 as it broke CI extensively.
LebedevRI
pushed a commit
to LebedevRI/julia
that referenced
this pull request
May 2, 2025
After the bindings change, there is quite a lot of garbage in here now at runtime (it does not de-duplicate entries added for bindings), so attempt to do a bit of that during serialization. Re-landing part of JuliaLang#58078
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Together, the commits save roughly 184 MB -> 159 MB by not storing unnecessary inferred IR