Skip to content

Conversation

@charleskawczynski
Copy link
Contributor

This is an attempt to close #55952.

@LilithHafner LilithHafner added performance Must go faster display and printing Aesthetics and correctness of printed representations of objects. labels May 3, 2025
@LilithHafner
Copy link
Member

FYI it might be hard to find a reviewer for this PR as it is a large diff designed to improve performance in displaying types that have size on the order of 1 million which is not a particularly high priority area afaict. You might want to seek out a reviewer on slack and include stronger justification in the OP of the PR.

@charleskawczynski
Copy link
Contributor Author

FYI it might be hard to find a reviewer for this PR as it is a large diff designed to improve performance in displaying types that have size on the order of 1 million which is not a particularly high priority area afaict.

I've seen stack traces ClimaLand whose frames take ~2 seconds to print, leading to traces that take tens of seconds on every error.

You might want to seek out a reviewer on slack and include stronger justification in the OP of the PR.

I already tried that, but nobody has responded:

image

Hearing "not a particularly high priority area afaict" is very discouraging as a Julia user. And folks at CliMA, myself included, have really struggled with some aspects of Julia and it's tooling.

For example: JuliaDebug/Cthulhu.jl#566 (comment).

I'm going to mark this PR as a draft for now since it's not yet ready for review (I've realized that my proposed solution in the issue is not sufficient for the context of how Base's show works).

@charleskawczynski charleskawczynski marked this pull request as draft May 10, 2025 18:17
@LilithHafner
Copy link
Member

Thanks for marking as a draft. When it is ready for review you can ping me and I'll try to help find someone (but no guarantees). Maybe someone at SciML will help review this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

display and printing Aesthetics and correctness of printed representations of objects. performance Must go faster

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve performance of depth-limited type printing in stack traces

2 participants