Fix lowering failure with type parameter in opaque closure #58307
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On nightly (going back to at least 1.10):
method-def-expr-binds static parameters to ssavalues, assigning thesessavalues in the beginning of the method signature, and then references the
ssavalues when constructing the final
svec. Example of such a signature:When expanding opaque closures, we currently take the svec from
method-def-expr-and forget about the assignments (hence "ssavalue with nodef"). This was probably an oversight, because they've already been assigned to
an unused variable :). This change just keeps the assignments block-prepended
to the
argtype.Since we require the
argtypeto be/return a tuple (this test case wraps thetuple in a UnionAll), this change really only upgrades the error we get:
Fix #49659