fix serializer compat with CodeInfos from v1.11 #58650
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
reviewed
Jun 6, 2025
|
|
||
| Serializer(io::IO) = Serializer{typeof(io)}(io) | ||
|
|
||
| const current_module = ScopedValue{Union{Nothing,Module}}(nothing) |
There was a problem hiding this comment.
Why isn't this just a struct field of the Serializer?
There was a problem hiding this comment.
Yeah it can be, I just wanted to avoid mutation.
There was a problem hiding this comment.
Ok, now I know why: there are other subtypes that won't have the field, so rather than need to add it to all of them I think the ScopedValue is better.
JeffBezanson
force-pushed
the
jb/sercompat111
branch
from
f73b7aa to
eb8818e
Compare
JeffBezanson
force-pushed
the
jb/sercompat111
branch
from
eb8818e to
e246595
Compare
KristofferC
pushed a commit
that referenced
this pull request
Aug 6, 2025
(cherry picked from commit 9f69961)
KristofferC
removed
the
backport 1.12
KristofferC
pushed a commit
that referenced
this pull request
Sep 5, 2025
(cherry picked from commit 9f69961)
KristofferC
pushed a commit
that referenced
this pull request
Sep 15, 2025
(cherry picked from commit 9f69961)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not totally sure this will work in 100% of cases, but I like to keep this working as much as possible.