test that various interface callables behave well #58829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsajko
added
test
nsajko
force-pushed
the
strings_search_restrict_IteratorSize_eltype
branch
2 times, most recently
from
ff5c26f to
a6a8bd2
Compare
I call callables that are meant to have methods added to by package authors "interface callables". Test that various interface callables are well-behaved in case of the introduction of a new applicable type. Only interface callables taking a single type argument are tested. The specific properties tested: * `max_methods` is high enough for good inference * the number of matching methods for a new type is not excessive The primary motivation for this change is to make any future lowering of the `max_methods` setting of the interface callables safer. To make the tests pass, fix a recent regression in base/strings/search.jl.
nsajko
force-pushed
the
strings_search_restrict_IteratorSize_eltype
branch
from
00ca50b to
a7fa52c
Compare
|
bump |
nsajko
added a commit
to nsajko/julia
that referenced
this pull request
Aug 24, 2025
A function which is meant to have methods added to it by users should have a small `max_methods` value, as world-splitting just leads to unnecessary invalidation in that case, in the context of the package ecosystem, where users are allowed to add arbitrarily many methods to such functions. xref PR JuliaLang#57884 xref PR JuliaLang#58788 xref PR JuliaLang#58829 xref PR JuliaLang#59091
nsajko
added a commit
to nsajko/julia
that referenced
this pull request
Aug 27, 2025
A function which is meant to have methods added to it by users should have a small `max_methods` value, as world-splitting just leads to unnecessary invalidation in that case, in the context of the package ecosystem, where users are allowed to add arbitrarily many methods to such functions. xref PR JuliaLang#57884 xref PR JuliaLang#58788 xref PR JuliaLang#58829 xref PR JuliaLang#59091
nsajko
added a commit
to nsajko/julia
that referenced
this pull request
Aug 29, 2025
A function which is meant to have methods added to it by users should have a small `max_methods` value, as world-splitting just leads to unnecessary invalidation in that case, in the context of the package ecosystem, where users are allowed to add arbitrarily many methods to such functions. xref PR JuliaLang#57884 xref PR JuliaLang#58788 xref PR JuliaLang#58829 xref PR JuliaLang#59091
|
I don't see any point to this. It seems to make the code a bit less readable for no visible benefit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I call callables that are meant to have methods added to by package authors "interface callables".
Test that various interface callables are well-behaved in case of the introduction of a new applicable type. Only interface callables taking a single type argument are tested.
The specific properties tested:
max_methodsis high enough for good inferencethe number of matching methods for a new type is not excessive
The primary motivation for this change is to make any future lowering of the
max_methodssetting of the interface callables safer.To make the tests pass, fix a recent regression in base/strings/search.jl.