Skip to content

Eliminate (almost) all invalidations by disabling world splitting #59091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Eliminate (almost) all invalidations by disabling world splitting #59091

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1450d94
Set max methods to 1 (mostly disable world splitting)
LilithHafner Jul 23, 2025
efa4faf
Also disable word splitting when the matches are not fully covered (r…
LilithHafner Jul 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Compiler/src/Compiler.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ baremodule BuildSettings
using Core: ARGS, include, Int, ===
using ..Compiler: >, getindex, length

global MAX_METHODS::Int = 3
global MAX_METHODS::Int = 1

if length(ARGS) > 2 && ARGS[2] === "--buildsettings"
include(BuildSettings, ARGS[3])
Expand Down
6 changes: 6 additions & 0 deletions Compiler/src/abstractinterpretation.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,12 @@ function abstract_call_gf_by_type(interp::AbstractInterpreter, @nospecialize(fun
return Future(CallMeta(Any, Any, Effects(), NoCallInfo()))
end

# Disable inference when not fully covered (similar to union split limit)
if !fully_covering(matches)
add_remark!(interp, sv, "Inference disabled for method without full coverage")
return Future(CallMeta(Any, Any, Effects(), NoCallInfo()))
end

(; valid_worlds, applicable) = matches
update_valid_age!(sv, valid_worlds) # need to record the negative world now, since even if we don't generate any useful information, inlining might want to add an invoke edge and it won't have this information anymore
if bail_out_toplevel_call(interp, sv)
Expand Down
Loading