rename GlobalMethods to methodtable 🚲 🏠
#59158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Going further, I believe most/all uses of this are with |
JeffBezanson
force-pushed
the
jb/allmethods
branch
from
5886fa5 to
7b6fe17
Compare
|
From triage:
Not from triage: I think |
JeffBezanson
force-pushed
the
jb/allmethods
branch
from
7b6fe17 to
d5ca5ac
Compare
JeffBezanson
changed the title
GlobalMethods to allmethods 🚲 🏠 GlobalMethods to methodtable 🚲 🏠
This was referenced Aug 2, 2025
KristofferC
pushed a commit
that referenced
this pull request
Aug 6, 2025
(cherry picked from commit f9b7d27)
yuyichao
added a commit
to yuyichao/Enzyme.jl
that referenced
this pull request
Aug 13, 2025
yuyichao
added a commit
to archlinuxcn/repo
that referenced
this pull request
Aug 13, 2025
wsmoses
pushed a commit
to EnzymeAD/Enzyme.jl
that referenced
this pull request
Aug 14, 2025
KristofferC
removed
the
backport 1.12
KristofferC
pushed a commit
that referenced
this pull request
Sep 5, 2025
(cherry picked from commit f9b7d27)
KristofferC
pushed a commit
that referenced
this pull request
Sep 15, 2025
(cherry picked from commit f9b7d27)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not a type, so I don't think it should use TypeCase, and it isn't really tied to globals though that isn't so important. This also might move in the future so maybe we should use
_allmethods? Or maybemethodtable(matchingjl_method_tablein C).