Fix printing of errors in juliac + searchsorted functions for LinearAlgebra #59299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topolarity
added
backport 1.12
topolarity
reviewed
Aug 15, 2025
Co-authored-by: Cody Tapscott <[email protected]>
Allows `eachindex(A::Vector{Float64}, B::Vector{Float64})` to be
`--trim`-compatible.
topolarity
approved these changes
Aug 15, 2025
|
Sounds good to include in Base. @gbaraldi, would you share an example of one of the |
|
It's not even poor performance. It's just not typestable if not inlined |
38 tasks
|
Merging this for now, but I will greatly appreciate any follow-up to move these changes to Base instead 🙂 |
topolarity
added a commit
that referenced
this pull request
Aug 18, 2025
…lgebra (#59299) We may want to move this changes to base proper. @LilithHafner should sort functions just always specialize on the `by`/`lt` params? It currently sometimes relies on inlining for good performance --------- Co-authored-by: Cody Tapscott <[email protected]> Co-authored-by: Cody Tapscott <[email protected]>
KristofferC
removed
the
backport 1.12
KristofferC
pushed a commit
that referenced
this pull request
Sep 5, 2025
…lgebra (#59299) We may want to move this changes to base proper. @LilithHafner should sort functions just always specialize on the `by`/`lt` params? It currently sometimes relies on inlining for good performance --------- Co-authored-by: Cody Tapscott <[email protected]> Co-authored-by: Cody Tapscott <[email protected]>
KristofferC
pushed a commit
that referenced
this pull request
Sep 15, 2025
…lgebra (#59299) We may want to move this changes to base proper. @LilithHafner should sort functions just always specialize on the `by`/`lt` params? It currently sometimes relies on inlining for good performance --------- Co-authored-by: Cody Tapscott <[email protected]> Co-authored-by: Cody Tapscott <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We may want to move this changes to base proper.
@LilithHafner should sort functions just always specialize on the
by/ltparams? It currently sometimes relies on inlining for good performance