Print task backtraces on sigquit #59389
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
You can alloca one, but note that it must be small, as there isn't much stack space. A few thousand elements is probably fine though, and possibly even too many. |
Member
Author
|
@vtjnash the one thing on that test is that race condition on the sleep. Any idea on how to make that properly reliable, without risking a zombie process? |
gbaraldi
force-pushed
the
gb/sigquittasks
branch
from
abf8b1d to
70e204b
Compare
vtjnash
reviewed
Sep 9, 2025
vtjnash
reviewed
Sep 9, 2025
Co-authored-by: Jameson Nash <[email protected]>
vtjnash
reviewed
Sep 9, 2025
vtjnash
reviewed
Sep 9, 2025
vtjnash
reviewed
Sep 9, 2025
Co-authored-by: Jameson Nash <[email protected]>
vtjnash
reviewed
Sep 12, 2025
Member
|
Looks like this has picked up some merge conflicts :( |
DilumAluthge
removed
the
merge me
vtjnash
approved these changes
Sep 24, 2025
vtjnash
added
merge me
DilumAluthge
removed
the
merge me
xal-0
pushed a commit
to xal-0/julia
that referenced
this pull request
Sep 30, 2025
KristofferC
pushed a commit
that referenced
this pull request
Oct 10, 2025
(cherry picked from commit 0635285)
KristofferC
pushed a commit
that referenced
this pull request
Oct 10, 2025
(cherry picked from commit 0635285)
KristofferC
pushed a commit
that referenced
this pull request
Oct 12, 2025
(cherry picked from commit 0635285)
KristofferC
pushed a commit
that referenced
this pull request
Oct 14, 2025
(cherry picked from commit 0635285)
KristofferC
removed
the
backport 1.12
vtjnash
reviewed
Nov 13, 2025
| else | ||
| jl_safe_fprintf(s, "\n[%d] signal %d: %s\n", getpid(), sig, strsignal(sig)); | ||
| if (sig == SIGQUIT) { | ||
| jl_print_task_backtraces(0); |
Member
There was a problem hiding this comment.
I must gripe that having this now conditionally smashing bt_data just 5 lines before we need to use it for useful fatal backtraces is very annoying
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a question here, printing task backtraces (or backtraces on exit regardless) requires a ct, but only because it needs a buffer. Can we alloca that buffer (malloc is probably illegal given signal context)