Skip to content

[backports-release-1.11] Revert "Make late gc lower handle insertelement of alloca use. (#58637)" #59447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[backports-release-1.11] Revert "Make late gc lower handle insertelement of alloca use. (#58637)" #59447

wants to merge 1 commit into from

Conversation

DilumAluthge
Copy link
Member

@DilumAluthge DilumAluthge commented Aug 31, 2025 •
edited
Loading

This reverts commit 47d905d (which backports #58637 to 1.11).

Targets backports-release-1.11 (#59336).

Motivation

Let's see if this fixes the llvmpasses CI job on backports-release-1.11 (#59336).

@DilumAluthge DilumAluthge changed the title Revert "Make late gc lower handle insertelement of alloca use. (#58637)" [backports-release-1.11] Revert "Make late gc lower handle insertelement of alloca use. (#58637)" Aug 31, 2025
@DilumAluthge
Copy link
Member Author

cc: @gbaraldi @vtjnash @serenity4

@DilumAluthge
Copy link
Member Author

DilumAluthge commented Aug 31, 2025 •
edited
Loading

Hmmm. This doesn't seem to fix the llvmpasses CI failure.

@DilumAluthge DilumAluthge deleted the dpa/revert-47d905d---backports-release-1.11 branch August 31, 2025 02:25
@DilumAluthge DilumAluthge restored the dpa/revert-47d905d---backports-release-1.11 branch August 31, 2025 18:36
@DilumAluthge DilumAluthge reopened this Aug 31, 2025
@DilumAluthge
Copy link
Member Author

DilumAluthge commented Aug 31, 2025 •
edited
Loading

This is definitely the first bad commit, but a simple revert doesn't seem sufficient to fix CI.

@DilumAluthge DilumAluthge force-pushed the dpa/revert-47d905d---backports-release-1.11 branch from a1f3393 to 53a0059 Compare August 31, 2025 18:38
@DilumAluthge
Copy link
Member Author

@gbaraldi Would you happen to know what's going on here?

@DilumAluthge
Copy link
Member Author

DilumAluthge commented Aug 31, 2025 •
edited
Loading

Okay, I rebased this PR, and now this PR does indeed fix the llvmpasses CI job.

@DilumAluthge DilumAluthge marked this pull request as ready for review August 31, 2025 19:21
@DilumAluthge DilumAluthge added the release Release management and versioning. label Aug 31, 2025
@DilumAluthge DilumAluthge force-pushed the dpa/revert-47d905d---backports-release-1.11 branch from 53a0059 to 4f6f2ef Compare September 1, 2025 13:17
@DilumAluthge DilumAluthge mentioned this pull request Sep 1, 2025
Merged
65 tasks
@DilumAluthge
Copy link
Member Author

Closed in favor of b04078d

@DilumAluthge DilumAluthge deleted the dpa/revert-47d905d---backports-release-1.11 branch September 1, 2025 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vtjnash vtjnash Awaiting requested review from vtjnash

@gbaraldi gbaraldi Awaiting requested review from gbaraldi

@serenity4 serenity4 Awaiting requested review from serenity4

Assignees

No one assigned

Labels

release Release management and versioning.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@DilumAluthge