Fix assume effects handling for gc_safe #59557
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vchuravy
approved these changes
Sep 15, 2025
|
Did this land in time for 1.12? |
|
Yes |
vchuravy
reviewed
Sep 15, 2025
test/ccall.jl
Outdated
| @test gc_safe_ccall() isa UInt64 | ||
| # check for the gc_safe store | ||
| @test occursin("store atomic i8 2", llvm) | ||
| @test Base.infer_effects(gc_safe_ccall, Tuple{}) == true |
There was a problem hiding this comment.
Error in testset ccall:
Test Failed at /Users/julia/.julia/scratchspaces/a66863c6-20e8-4ff4-8a62-49f30b1f605e/agent-cache/default-honeycrisp-XG3Q6T6R70.0/build/default-honeycrisp-XG3Q6T6R70-0/julialang/julia-master/julia-7bde44d5c7/share/julia/test/ccall.jl:1981
Expression: Base.infer_effects(gc_safe_ccall, Tuple{}) == true
Evaluated: (!c,!e,+n,!t,!s,!m,!u,+o,!r) == true
ERROR: LoadError: Test run finished with errors
aviatesk
pushed a commit
that referenced
this pull request
Sep 16, 2025
28 tasks
xal-0
pushed a commit
to xal-0/julia
that referenced
this pull request
Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #59552