Only apply Base.Sort.SubArrayOptimization when iszero(v.offset1) #59572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LilithHafner
added
bugfix
N5N3
approved these changes
Sep 16, 2025
KristofferC
pushed a commit
that referenced
this pull request
Sep 17, 2025
) Fixes #59569 Thanks @N5N3 for finding the bug! For 1.13, we could re-enable this optimization and propagate the information to the sub-alg or have the sub-alg's embedded indices be relative to `kw.lo` rather than absolute. For backports, this minimal change is more appropriate. (cherry picked from commit 067b013)
KristofferC
pushed a commit
that referenced
this pull request
Sep 17, 2025
) Fixes #59569 Thanks @N5N3 for finding the bug! For 1.13, we could re-enable this optimization and propagate the information to the sub-alg or have the sub-alg's embedded indices be relative to `kw.lo` rather than absolute. For backports, this minimal change is more appropriate. (cherry picked from commit 067b013)
25 tasks
59 tasks
24 tasks
KristofferC
removed
the
backport 1.12
xal-0
pushed a commit
to xal-0/julia
that referenced
this pull request
Sep 30, 2025
…iaLang#59572) Fixes JuliaLang#59569 Thanks @N5N3 for finding the bug! For 1.13, we could re-enable this optimization and propagate the information to the sub-alg or have the sub-alg's embedded indices be relative to `kw.lo` rather than absolute. For backports, this minimal change is more appropriate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #59569
Thanks @N5N3 for finding the bug!
For 1.13, we could re-enable this optimization and propagate the information to the sub-alg or have the sub-alg's embedded indices be relative to
kw.lorather than absolute. For backports, this minimal change is more appropriate.