Skip to content

move REPL/src/Terminals.jl into Base to work around significant invalidations from it #59590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 19, 2025
Merged

move REPL/src/Terminals.jl into Base to work around significant invalidations from it #59590

merged 1 commit into from
Sep 19, 2025

Conversation

@KristofferC
Copy link
Member

@KristofferC KristofferC commented Sep 18, 2025

A bit ugly but I don't think this is so bad. Will be a bit more annoying to Revise this file but it is quite low traffic.

Fixes #59494

julia> using GMT

julia> @time plot(rand(2,2))
  0.002897 seconds (609 allocations: 29.766 KiB)

@KristofferC KristofferC requested a review from vtjnash September 18, 2025 08:19
@KristofferC KristofferC added REPL Julia's REPL (Read Eval Print Loop) latency Latency backport 1.12 Change should be backported to release-1.12 labels Sep 18, 2025
@KristofferC KristofferC mentioned this pull request Sep 18, 2025
Closed
@KristofferC
Copy link
Member Author

KristofferC commented Sep 19, 2025

#59494 (comment) tells me that this is not just an issue with the package itself (GMT) but a general problem. If you ever call print(x) where X is a vector you get invalidated by loading the REPL. So I think it makes sense to do this.

@KristofferC KristofferC merged commit a25decd into master Sep 19, 2025
5 of 7 checks passed
@KristofferC KristofferC deleted the kc/terminals_repl branch September 19, 2025 08:44
KristofferC added a commit that referenced this pull request Sep 19, 2025
@KristofferC
move REPL/src/Terminals.jl into Base to work around significant inv…
db87ab5 
…alidations from it (#59590)

(cherry picked from commit a25decd)
@KristofferC KristofferC mentioned this pull request Sep 24, 2025
Merged
24 tasks
@KristofferC KristofferC removed the backport 1.12 Change should be backported to release-1.12 label Sep 24, 2025
@DilumAluthge DilumAluthge mentioned this pull request Sep 28, 2025
Closed
xal-0 pushed a commit to xal-0/julia that referenced this pull request Sep 30, 2025
@KristofferC @xal-0
move REPL/src/Terminals.jl into Base to work around significant inv…
5f23da1 
…alidations from it (JuliaLang#59590)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vtjnash vtjnash Awaiting requested review from vtjnash

Assignees

No one assigned

Labels

latency Latency REPL Julia's REPL (Read Eval Print Loop)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

precompiling on V.11, V1.12, ... may loose half the precompilation work

2 participants

@KristofferC