Apply an inference barrier to annot printstyled #59596
Conversation
In 6d78a4a we introduced an inference barrier to the various AnnotatedX/StyledStrings methods whose implementations are frustratingly split between Base and a Stdlib, to ease the pain of invalidations. As has recently been pointed out in the re-opened JuliaLang#57997, this missed a `printstyled` method. We address that here, together with a tweak to the StyledStrings library. Reported-by: Neven Sajko <[email protected]>
tecosaur
added
display and printing
|
I've made a push in creating this PR before we get to the weekend because of how much time/attention this has been taking from other people, but it's late for me and I won't be up long enough to test this today. I'll verify that this indeed works as intended in the next day or two. |
|
Gah, there seems to be a load order issue with |
|
Adding a Is this the best way to resolve the load order issue? |
|
Why do these need |
|
We've put the invalidation barriers in a |
|
Ah, ok, then an empty function above should work fine. |
In 6d78a4a we introduced an inference barrier to the various AnnotatedX/StyledStrings methods whose implementations are frustratingly split between Base and a Stdlib, to ease the pain of invalidations. As has recently been pointed out in the re-opened #57997, this missed a `printstyled` method. We address that here, together with a tweak to the StyledStrings library. Reported-by: Neven Sajko <[email protected]> (cherry picked from commit 406d37b)
In 6d78a4a we introduced an inference barrier to the various AnnotatedX/StyledStrings methods whose implementations are frustratingly split between Base and a Stdlib, to ease the pain of invalidations. As has recently been pointed out in the re-opened JuliaLang#57997, this missed a `printstyled` method. We address that here, together with a tweak to the StyledStrings library. Reported-by: Neven Sajko <[email protected]>
2 participants
In 6d78a4a we introduced an inference barrier to the various AnnotatedX/StyledStrings methods whose implementations are frustratingly split between Base and a Stdlib, to ease the pain of invalidations.
As has recently been pointed out in the re-opened #57997, this missed a
printstyledmethod. We address that here, together with a tweak to the StyledStrings library in JuliaLang/StyledStrings.jl#124.